Skip to content

A couple of changes #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 26, 2018
Merged

A couple of changes #6

merged 5 commits into from
May 26, 2018

Conversation

stefansundin
Copy link
Contributor

@stefansundin stefansundin commented May 12, 2018

Hey there again.

After having used the program for a couple of weeks, I decided to make some changes.

  • The menu was taking way too long to load, to the point that it was a bad user experience. My workaround to this is to not clear the list of services when you bring up the list. Instead, I think the trade-off of seeing the old state is Ok. It still refreshes the list and you'll see the updated list within a few seconds.
    • This could possibly be improved slightly by immediately modifying the state when you click to start/stop a service. But I have zero swift skills, so I don't know how to do that.
  • Added "Start all" and "Stop all" items.
  • Moved the refresh indicator to the bottom.

Hope you like it!

@stefansundin
Copy link
Contributor Author

I added the ability to restart services by revealing alternative menu items (with the Option key). It works great so well that I impressed myself.

Please give it a try @andrewn. :)

@andrewn
Copy link
Owner

andrewn commented May 22, 2018

Hi @stefansundin, this is great stuff! I'll give it a try soon and then create a new release.

altItem.isEnabled = item.isEnabled
altItem.isAlternate = true
altItem.isHidden = true
altItem.keyEquivalentModifierMask = NSAlternateKeyMask
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this line is actually needed...

@andrewn andrewn merged commit cfbbee7 into andrewn:master May 26, 2018
@andrewn
Copy link
Owner

andrewn commented May 26, 2018

Thanks again for this, it's great!

I added a change so that when the command has finished executing, the list is queried again. This should mean that the list is accurate the next time it's opened.

I've created a new release.

@stefansundin
Copy link
Contributor Author

Nice. 👍

It may be worth mentioning the option-key restart feature in the README as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants