Skip to content

Conversation

p4-k4
Copy link

@p4-k4 p4-k4 commented Apr 9, 2023

No description provided.

@anasfik
Copy link
Owner

anasfik commented Apr 10, 2023

Hello, I guess it is better to just mention it without specifying the solution in the library documentation, it should be acknowledged by the package user.. ?

@p4-k4
Copy link
Author

p4-k4 commented Apr 10, 2023

@anasfik Your package documentation is a prime location for such requirements to exist IMO . I know it's a platform specific requirement but having it in package documentation can serve as both a reminder or new knowledge to experienced and learning users. Up to you, but could potentially reduce future duplicate issues too.

@anasfik
Copy link
Owner

anasfik commented Apr 10, 2023

does make sense, but then we will need to do the same for other platforms since they can end up resulting un the same thing, don't you agree ?

@p4-k4
Copy link
Author

p4-k4 commented Apr 10, 2023

Of course - I just happened to be doing MacOS builds - so I only added a guide for that. The Permissions section I added allows for the other platforms I guess though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants