Add custom fetch http client for web streams #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anasfik please check when you can :) |
|
Hi, sorry for late respond, I will check it rn. |
|
Strange, the test ran locally just fine :/ |
|
Hi, there is no issue with your code, it is an OpenAI's, merging.. |
|
especially an issue right now with the /edits API, which throws that the model: |
|
I'm still seeing an issue with stream on Flutter web - dart_openai: ^4.0.0 - Streaming works great on other platforms, but not on web. It seems the entire response arrives, and is then released at once to the code My understanding from this thread, is that this should be resolved by now? Am I missing a configuration step? Many thanks!! 🙏🏻 |
|
is it fixed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this issue I have added a drop in conditional import to create an http client from the fetch client if the app is compiled for the web.
This allows Flutter Web clients to get streamed chat completions responses word by word providing a better user experience for chat applications using this package.
PD: This change doesn't affect unit tests or other platforms and it is implemented with minimum overhead.