Skip to content

Use a frame_max of 131072 by default for RabbitMQ 4.1.0 compatibility #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

Use a frame_max of 131072 by default for RabbitMQ 4.1.0 compatibility #787

merged 1 commit into from
Mar 26, 2025

Conversation

michaelklishin
Copy link
Contributor

@michaelklishin michaelklishin commented Mar 26, 2025

Just like nearly all client libraries do.

In RabbitMQ 4.1.0, the pre-authentication default changes to 8192 to accommodate larger JWT tokens, which the current value in this client won't be compatible with. See [1].

This default matches what RabbitMQ itself, the Java and .NET clients have been using since 2007.

  1. https://github.com/rabbitmq/rabbitmq-server/blob/main/release-notes/4.1.0.md#initial-amqp-0-9-1-maximum-frame-size

Just like nearly all client libraries do.

In RabbitMQ 4.1.0, the pre-authentication default changes
to 8192 to accommodate for larger JWT frames, which
the current value in this client won't be compatible with.
See [1].

This default matches what RabbitMQ itself, the Java and .NET clients have been using since 2007.

1. https://github.com/rabbitmq/rabbitmq-server/blob/main/release-notes/4.1.0.md#initial-amqp-0-9-1-maximum-frame-size
@michaelklishin michaelklishin changed the title Use a frame_max of 131072 by default Use a frame_max of 131072 by default for RabbitMQ 4.1.0 compatibility Mar 26, 2025
@michaelklishin
Copy link
Contributor Author

rabbitmq/rabbitmq-server#13541 is the server change that bumps the minimum, first shipping in 4.1.0 in the next few weeks.

@michaelklishin
Copy link
Contributor Author

@cressie176 given that RabbitMQ 4.1.0 will ship in a few weeks, it would be great to have a new release of this library with this higher default.

With the unfortunate default used today, this library won't be able to connect to a 4.1.0 node.

@cressie176
Copy link
Collaborator

Thanks @michaelklishin, I'll issue a new release sometime this week. Appreciate you looking out for amqplib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants