Fix amp4email demo XHR endpoint inconsistent header #6826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangsu
reviewed
Jul 22, 2024
netlify/functions/examples_static_samples_json_cart/examples_static_samples_json_cart.js
Show resolved
Hide resolved
erwinmombay
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gmail team has found out that this endpoint is returning inconsistent Access-Control-Allow-Origin header. It could be because it enables
publiccache. The problem is that this header depends on the origin header and therefore it cannot properly be cached without messing the response header up. This PR disables the cache on the Netlify. Given it is only a demo, I do not expect this to become a significant cost problem.@zhangsu