Skip to content

allow adding '%' to volume command #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

allow adding '%' to volume command #358

wants to merge 3 commits into from

Conversation

@m4rch3n1ng
Copy link

@m4rch3n1ng m4rch3n1ng commented Jul 22, 2025 •
edited
Loading

now parses options such as playerctl volume 45% (which is equivalent to playerctl volume 0.45) and playerctl volume 5%+ (which is equivalent to playerctl volume 0.05+)

as a drive-by fix in [aa558c5] also avoid a heap-buffer overflow, as it was reading from index -1 when the string was empty (i.e. when calling playerctl volume ""). when running with asan, i got this error before this pr:

=================================================================
==404784==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x7b9262be110f at pc 0x563727a62061 bp 0x7ffc855a8810 sp 0x7ffc855a8800
READ of size 1 at 0x7b9262be110f thread T0
    #0 0x563727a62060 in playercmd_volume ../playerctl/playerctl-cli.c:424
    #1 0x563727a6727c in main ../playerctl/playerctl-cli.c:1267
    #2 0x7f7263f146b4  (/usr/lib/libc.so.6+0x276b4) (BuildId: 468e3585c794491a48ea75fceb9e4d6b1464fc35)
    #3 0x7f7263f14768 in __libc_start_main (/usr/lib/libc.so.6+0x27768) (BuildId: 468e3585c794491a48ea75fceb9e4d6b1464fc35)
    #4 0x563727a5f764 in _start (/home/may/projects/playerctl/build/playerctl/playerctl+0x7764) (BuildId: bfb9bf259ecef198d7b8b26cdd423b31888e79bc)

@m4rch3n1ng
fix heap-buffer-overflow when passing empty string to volume
aa558c5 
when passing an empty string to `playerctl volume` it would then try to
read `len - 1`, which would be `-1`, which would be an invalid index
@m4rch3n1ng m4rch3n1ng changed the title allow addig '%' to volume command allow adding '%' to volume command Jul 22, 2025
@m4rch3n1ng
allow giving percentages when setting volume
4c5e7bb 
allows things like `playerctl 45%`, which would be equivalent to
`playerctl 0.45`, and `playerctl 5%+`, which would be equivalent to
`playerctl 0.05+`.
@m4rch3n1ng
update documentation to reflect new options
ccde3f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@m4rch3n1ng