Make core generic over float types #373
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make a OptFloat trait - Provide PANOC constants implemented for f32 and f64 - Use somewhat arbitrary values for f32 PANOC constants, unclear how good these are. These should be looked at. - Add some tests for f32 (some of which are failing!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Changes
I wanted to try the core crate out on a microcontroller that just has hard-floats for f32, so I hacked this together. I'm only using PANOC without constraints, so I'm not sure if anything really works that well outside of what I used. Perhaps the complexity is somewhat inevitable to support f32/f64, but it's annoying how much extra boilerplate is added with this. Nonetheless, it could be a good basis for adding f32 support here.
Associated Issues
TODOs
CHANGELOG(s)CHANGELOG,Cargo.tomlandVERSION)