Fix trimmed headers in helm-org-rifle-show-path mode #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default width for this function is 79 characters, so it many headings end up trimmed. Not sure how it went unnoticed, because I believe it's the code path taken by default settings :)
Closed
|
@karlicoss Apologies for overlooking this PR. This is probably a good change to make. At least, we need to pass something so the default width isn't used. But I wonder if we should make it configurable, and e.g. if the user wants to use window-width, if that value should be captured when the search begins and a variable used in this expression. What do you think? Thanks. |
|
I think I would rather have the headline fold to another line instead of truncate as a default. When the headline includes links for example, they tend to get truncated in a manner that withholds the link description, making it harder to select between headlines. |
natask
added a commit
to natask/org-rifle
that referenced
this pull request
Dec 31, 2020
alphapapa#63 and alphapapa#41 from main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default width for this function is 79 characters, so it many headings end up trimmed.
Not sure how it went unnoticed, because I believe it's the code path taken by default settings :)