-
Couldn't load subscription status.
- Fork 46
Support downloading media #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks, that looks useful. I pushed a few changes on top of your branch. If you concur, I'll merge it. |
babc9f4 to
c72199e
Compare
|
Thanks for adding the bindings. Part of me feels like it should be an uppercase letter, in case we want to use lowercase-D for a more mundane command in the future, but I don't feel too strongly about it. What do you think? |
Either works fine for me, all I need is the command somewhere so that I get access to the flies sent to me. I'll switch it to uppercase, for both the room command and the transient, I guess? |
a03c96a to
9df7f55
Compare
In the modern days of authenticated media this doesn't do anything useful if the user has configured browse-url to open things in something other than eww.
Bind this to both the room keymap, and the transient with the key "D" (for download).
9df7f55 to
effc225
Compare
|
Thanks, @viiru-! |
|
The downloading fails for me for the video posted by amadaluzia in the Emacs room on 2025-04-16/17 (depending on your time zone). I get This is the only download URL I could recall seeing, so I haven't tested anything else. |
|
And re-testing with a fresh config, I get Loading |
See <#323 (comment)>. Reported-by: Phil Sainty <[email protected]>
See <#323 (comment)>. Reported-by: Phil Sainty <[email protected]>
|
Thanks for testing and reporting, @phil-s. The two commits I just pushed should solve those things, with one exception: pressing |
|
Confirming that the fixes work for me. |
Add a function for downloading media, and use it as the default action for m.audio, m.file and m.video.
Now that authenticated media is the expected situation opening these as links in an external browser no longer works, so try this instead.
"Open in the chosen application for this mime type" would be nice as well, but based on looking at the way Gnus does this it seems harder than expected. Perhaps there is something I don't understand here..