Log hostnames instead of object identifiers #2033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this logged:
Importing CNAME / A records for #<Host:0x0000ffff70331ba0>
Importing CNAME / A records for #<Host:0x0000ffff70331a60>
Importing CNAME / A records for #<Host:0x0000ffff70331920>
Which is not very useful.
Pull the repeated bit of the message out of the loop, and then just log
the hostnames, so we should get:
Importing CNAME / A records for 128 hosts:
foo.bar.com
bar.baz.com
...
Instead
callumknights
approved these changes
Oct 3, 2025
nacnudus
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this logged:
Which is not very useful.
Pull the repeated bit of the message out of the loop, and then just log the hostnames, so we should get:
Instead