[WHIT-1981] Add rake task for MOD covenant pledges finder imports #3330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauraghiorghisor-tw
force-pushed
the
add-rake-task-for-mod-imports
branch
3 times, most recently
from
6c05cb1 to
ac9726b
Compare
| afc_business = ArmedForcesCovenantBusiness.new(**document_data[:attributes].deep_symbolize_keys) | ||
|
|
||
| unless dry_run | ||
| afc_business.save |
There was a problem hiding this comment.
We did a sleep on the IPO rake task to ensure the order in the csv is preserved, but this one will take forever as it's a much larger csv file, and I think we're ok with the documents being created in a slightly messy order.
|
|
||
| unless dry_run | ||
| if dry_run | ||
| afc_business.valid? |
There was a problem hiding this comment.
This is a bit superficial on the dry run but it can at least show us any date validations etc.
- this imports data from csv and creates business documents
- add succcesful logs - add error logs - add total error count The document `save` actually registers `:base` errors on the model for 422 errors from publishing-api, which will be handy to count. We will likely get some console logs from the request itself, but a custom log will be easier to read and search for.
- Some capital case corrections - Importing the bespoke pledges as they are rather than trying to do anything extra with the "-"
- Add line to summary - Capital letter corrections to the body template - Changed date preposition so it reads better in the filters - Moved "Other" option to be last
lauraghiorghisor-tw
force-pushed
the
add-rake-task-for-mod-imports
branch
from
ac9726b to
50446f3
Compare
- needed to test emails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of creating a finder for MOD armed forces covenant pledges, originally here https://www.gov.uk/government/publications/armed-forces-corporate-covenant-signed-pledges.
We're importing the data from a csv via a rake task, from csv file here: https://docs.google.com/spreadsheets/d/1kUmeMRQPhO8qplC4Lbh3DRXdftYczxW5TedjRvWjolQ/edit?gid=1449320752#gid=1449320752
Testing:
Content - to be confirmed with department. Comms in email thread.
See revised import file.
Import screenshots:
JIRA: https://gov-uk.atlassian.net/browse/WHIT-1981