Skip to content

PP-12517 Update logging for rate limiter exceptions #2003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

PP-12517 Update logging for rate limiter exceptions #2003

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce24127
PP-12517 Update logging for rate limiter exceptions
DomBelcher Jun 4, 2024
27c14bb
[squash] Add logging for error stacktrace
DomBelcher Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/main/java/uk/gov/pay/api/filter/ratelimit/RedisRateLimiter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,17 @@
import uk.gov.pay.api.managed.RedisClientManager;

import javax.inject.Singleton;
import java.io.PrintWriter;
import java.io.StringWriter;
import java.time.LocalDateTime;
import java.time.temporal.ChronoField;
import java.util.concurrent.Callable;

@Singleton
public class RedisRateLimiter {
private static final Logger LOGGER = LoggerFactory.getLogger(RedisRateLimiter.class);
private static final StringWriter stringWriter = new StringWriter();
private static final PrintWriter printWriter = new PrintWriter(stringWriter);
private final MetricRegistry metricsRegistry;

private RateLimitManager rateLimitManager;
Expand All @@ -42,7 +46,11 @@ void checkRateOf(String accountId, RateLimiterKey key)
int rateLimitInterval = rateLimitManager.getRateLimitInterval(accountId);
count = updateAllowance(key.getKey(), rateLimitInterval);
} catch (Exception e) {
LOGGER.info("Failed to update allowance. Cause of error: " + e.getMessage());
LOGGER.info(String.format("Failed to update allowance. Cause of error: %s", e));
e.printStackTrace(printWriter);
LOGGER.info(stringWriter.toString());
stringWriter.flush();

// Exception possible if redis is unavailable or perMillis is too high
throw new RedisException();
}
Expand Down