Bump minimum version of requests to 2.32.5 #1261
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had issues with 2.32.2 as noted in: alphagov/notifications-api@b707247 The cause of the issues has been reverted: > The SSLContext caching feature originally introduced in 2.32.0 has created > a new class of issues in Requests that have had negative impact across a number > of use cases. The Requests team has decided to revert this feature as long term > maintenance of it is proving to be unsustainable in its current iteration. – https://github.com/psf/requests/releases/tag/v2.32.5 We can now bump to the latest version which gives us some security patches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had issues with 2.32.2 as noted in: alphagov/notifications-api@b707247
The cause of the issues has been reverted:
– https://github.com/psf/requests/releases/tag/v2.32.5
We can now bump to the latest version which gives us some security patches.