-
Notifications
You must be signed in to change notification settings - Fork 39
Safe placeholder guidance for personalisation #5491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Info around placeholders and restructuring of personalisation page
Added guidance on safe placeholder
This comment was marked as outdated.
This comment was marked as outdated.
Changed structure of guidance
Tweaked wording
@rparke - hey Richard, this is ready for review please :) |
Just checking, we don't want this merging to main by itself right? We want it merging to the feature branch for placeholder injection and testing along with the rest of the prototype, then merging after any usability testing changes. |
Yeah it'll need adding to the prototype in prep for the usability session on Thursday |
Cool, it all looks good to me, but we will need to make sure everything gets merged into the right place in the right order. |
updated placeholder syntax from 'make safe' to 'secure'
@rparke I've updated the placeholder name from make_safe to secure now. And added the 'edit email template' page content too. So it's good to add to the prototype after you've reviewed it |
Added correct secure placeholder syntax as was missing an ')'
@rparke tagging you as I've added the correct placeholder syntax (Edit email template page commit), Thanks! |
Added safe placeholder guidance. Restructured content to accommodate new guidance.
Please could we add a preview, thanks.