Skip to content

Conversation

saimaghafoor
Copy link
Contributor

Added safe placeholder guidance. Restructured content to accommodate new guidance.

Please could we add a preview, thanks.

Info around placeholders and restructuring of personalisation page
Added guidance on safe placeholder
@BlessedDev

This comment was marked as outdated.

Changed structure of guidance
@BlessedDev
Copy link
Contributor

placeholder content

@saimaghafoor saimaghafoor requested a review from rparke June 3, 2025 11:25
@saimaghafoor
Copy link
Contributor Author

@rparke - hey Richard, this is ready for review please :)

@rparke
Copy link
Contributor

rparke commented Jun 4, 2025

@rparke - hey Richard, this is ready for review please :)

Just checking, we don't want this merging to main by itself right? We want it merging to the feature branch for placeholder injection and testing along with the rest of the prototype, then merging after any usability testing changes.

@saimaghafoor
Copy link
Contributor Author

Yeah it'll need adding to the prototype in prep for the usability session on Thursday

@rparke
Copy link
Contributor

rparke commented Jun 4, 2025

Yeah it'll need adding to the prototype in prep for the usability session on Thursday

Cool, it all looks good to me, but we will need to make sure everything gets merged into the right place in the right order.

@saimaghafoor
Copy link
Contributor Author

@rparke I've updated the placeholder name from make_safe to secure now. And added the 'edit email template' page content too. So it's good to add to the prototype after you've reviewed it

Added correct secure placeholder syntax as was missing an ')'
@saimaghafoor
Copy link
Contributor Author

@rparke tagging you as I've added the correct placeholder syntax (Edit email template page commit), Thanks!

@quis quis marked this pull request as draft September 2, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants