-
Notifications
You must be signed in to change notification settings - Fork 347
Allow removal of Content Licence information in the GOV.UK footer component #6191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Allow removal of Content Licence information in the GOV.UK footer component #6191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for proposing this @NickColley. The technical changes look good and the review app seemed OK to me 🙌🏻
@hazalarpalikli @mia-allers-gds @CharlotteDowns any chance one of you could have a look at the Footer page of the preview app to confirm things look OK design-wise for the examples without licence, please?
packages/govuk-frontend/src/govuk/components/footer/footer.yaml
Outdated
Show resolved
Hide resolved
Oh, we'll need a CHANGELOG entry for this new feature as well. Are you find drafting it @NickColley or would you prefer we add it before merging? |
@romaricpascal I'll make sure to add the CHANGELOG entry good spot 👍🏻 |
Co-authored-by: Nick Colley <[email protected]>
Since we can now hide the content licence entirely, we need to handle the cases when a user may have no content licence but some inline lists or custom meta info. Co-authored-by: Nick Colley <[email protected]>
6069a8e
to
e7aeaa1
Compare
Co-authored-by: Romaric Pascal <[email protected]> Co-authored-by: Nick Colley <[email protected]>
Co-authored-by: Nick Colley <[email protected]>
e7aeaa1
to
b32124b
Compare
@romaricpascal added first draft of the CHANGELOG entry and commited your suggestion ready for final review. |
I have coded this up but I understand there may be a reason why this proposal is not accepted or wanted so no hard feelings if it is not accepted 😄
At Companies House (https://find-and-update.company-information.service.gov.uk/) we do not use the OGL Licence:
If we want to use the
govukFooter
Nunjucks macro we have to manually hide the OGL Licence by doing something like:or by maintaining our own Nunjucks macro, where we then dont benefit from any markup changes for example when the crown logo was added recently.
This pull request introduces:
contentLicence
tofalse
which then hides it.Screenshots
Companies House example
GOV.UK Design System guidance