Align inverse headers with the new styles of the gem component #5034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannalaakso
force-pushed
the
update-inverse-header
branch
from
b7644e7 to
84cdef7
Compare
hannalaakso
force-pushed
the
update-inverse-header
branch
from
c279f33 to
4303e94
Compare
hannalaakso
changed the title
hannalaakso
force-pushed
the
update-inverse-header
branch
from
4303e94 to
40c4726
Compare
hannalaakso
force-pushed
the
update-inverse-header
branch
from
40c4726 to
54f4c2f
Compare
hannalaakso
force-pushed
the
update-inverse-header
branch
from
6913d6a to
c916ab6
Compare
hannalaakso
force-pushed
the
update-inverse-header
branch
from
c916ab6 to
1f1671d
Compare
hannalaakso
force-pushed
the
update-inverse-header
branch
from
1f1671d to
df6e0cc
Compare
jon-kirwan
reviewed
Oct 13, 2025
| <% end %> | ||
| <%= render "govuk_publishing_components/components/lead_paragraph", { | ||
| text: lead_para, | ||
| inverse: true, |
There was a problem hiding this comment.
Nice, I guess we should be able to fully remove this option once it's removed from https://github.com/alphagov/collections/blob/main/app/views/taxons/_page_header.html.erb#L17.
As the new style inverse header (with light blue background) doesn't require white text, remove setting it with inverse styles. Add class to links to style with the new inverse header style black.
A design decision was made to retain the blue background on the CSV previews for now, reflecting the fact that the context is different than for the full page header that will be light blue with the new style inverse header.
jon-kirwan
force-pushed
the
update-inverse-header
branch
from
df6e0cc to
b0fbdac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove the white text styles from the Service Manual and Service Toolkit headers, as well as making links black.
Update the CSV preview to use the HTML publication variant of the inverse header.
Why
This aligns the typography styles inside the header on the Service Manual and Service Toolkit with the updated the new style gem inverse header component.
A design decision was made to retain the deeper blue header colour in the context of document views for now, so the header on the CSV preview will use the HTML publication variant of the inverse header which is keeping its blue background.
https://gov-uk.atlassian.net/jira/software/c/projects/NAV/boards/1422?selectedIssue=NAV-18210
Screenshots?
The 'After' include the updates to to the gem component - see 'Depends on'.
Before
After
Before
After
Before
After (no difference)
Depends on
alphagov/govuk_publishing_components#5053 - I've added a Do Not Merge label until the gem PR has been merged.
Fixes https://gov-uk.atlassian.net/jira/software/c/projects/NAV/boards/1422?selectedIssue=NAV-18210.