Add indexes for users search #2240
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a GIN index on LOWER(name) to optimize case-insensitive searches for users.
Add a GIN index on LOWER(email) to optimize case-insensitive searches for users. We already have a unique index on email but we cannot make gin indexes unique so we need to add a separate index for searches.
|
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2240.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Add GIN indexes on LOWER(name) and LOWER(email) to the users table to optimize searches using the name and email filters on the users index page. Performance isn't currently an issue for these searches, but adding these indexes should ensure they remain performant as more users sign up.
We need to ensure that the forms-admin user has the
rds_extensionrole in order for the migration withenable_extension "pg_trgm"to run. We also need to ensure thatpg_trgmis in therds.allowed_delegated_extensionsfor the database.Things to consider when reviewing