Skip to content

Conversation

thomasiles
Copy link
Contributor

@thomasiles thomasiles commented Aug 7, 2025

What problem does this pull request solve?

Trello card: https://trello.com/c/ctgaaiHF/2435-frontend-work-to-select-a-group-to-send-forms-to

This is a work in progress to flesh out the view for moving form between
groups.

- Add content from deigns to the view
- Add form components based on number of groups
- Add simple unit tests

Still to do:

- Clarify if select and autocomplete should start off blank, like radio buttons
- Move content into locale files
- Check against designs
- Write commit messages
image

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

chao-xian and others added 10 commits August 5, 2025 17:56
This restricts moving Forms between Groups to only Org Admins.
This is a very rudimentary version of the feature, with no specs and no filtering of Groups that receive the form.
Also tidies up some data issues.
All the specs are ignored atm.
This is a work in progress to flesh out the view for moving form between
groups.

- Add content from deigns to the view
- Add form components based on number of groups
- Add simple unit tests

Still to do:

- Clarify if select and autocomplete should start off blank, like radio buttons
- Move content into locale files
- Check against designs
- Write commit messages
Copy link

sonarqubecloud bot commented Aug 7, 2025

Copy link

github-actions bot commented Aug 7, 2025

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2122.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@chao-xian chao-xian force-pushed the add-move-forms branch 2 times, most recently from 37bca61 to 5d6f2d4 Compare August 8, 2025 14:00
@chao-xian chao-xian force-pushed the add-move-forms branch 7 times, most recently from ee7d70b to 209b9c5 Compare September 2, 2025 16:49
@chao-xian chao-xian force-pushed the add-move-forms branch 3 times, most recently from caef25d to 0b5e672 Compare September 3, 2025 16:12
Base automatically changed from add-move-forms to main September 4, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants