Skip to content

Conversation

@lfdebrux
Copy link
Member

What problem does this pull request solve?

Trello card: https://trello.com/c/moEwoMm8/2242-add-usage-report-for-branching-feature

This PR adds a feature report for how many live forms are using secondary skip routes (and therefore branch routing).

It also changes the format of tables when looking at forms with routes to include the number of branch routes as well as the overall number of routes.

This PR is based off of #1970 to reduce the amount of changes needed.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@lfdebrux lfdebrux force-pushed the ldeb-add-branch-routes-feature-report branch from 84f0f8f to 4ed85da Compare May 23, 2025 09:57
@sonarqubecloud
Copy link

@github-actions
Copy link

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-1971.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@lfdebrux
Copy link
Member Author

This is superseded by #1992 .

@lfdebrux lfdebrux closed this May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant