Skip to content

Conversation

thomasiles
Copy link
Contributor

Small refactor of passing values to the skip controller views

Replace template locals with a single instance variable.

  • Remove back_link from skip controller
  • Remove template local from skip_controller
  • Add view tests for secondary_skip#edit

Trello card:

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

@thomasiles thomasiles force-pushed the refactor-skip-controller branch 2 times, most recently from b5327ee to 1bc3f09 Compare December 6, 2024 11:01
@thomasiles thomasiles force-pushed the refactor-skip-controller branch from 1bc3f09 to 9795c73 Compare December 12, 2024 10:30
Copy link

@thomasiles
Copy link
Contributor Author

closing because this is too old to be relevant now

@thomasiles thomasiles closed this Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant