Ensure form is present in draft question in tests

The previous commit broke some tests, as some tests were using test data
for draft_question without a corresponding form existing.

This commit adds a form to these tests to make them more realistic and
fix the tests.

Author: DavidBiddle

spec/input_objects/pages/address_settings_input_spec.rb

@@ -1,8 +1,9 @@
 require "rails_helper"
 
 RSpec.describe Pages::AddressSettingsInput, type: :model do
+  let(:form) { create :form }
   let(:address_settings_input) { build :address_settings_input, draft_question: }
-  let(:draft_question) { build :draft_question, answer_type: "address", form_id: 1 }
+  let(:draft_question) { build :draft_question, answer_type: "address", form_id: form.id }
 
   it "has a valid factory" do
     expect(address_settings_input).to be_valid

spec/input_objects/pages/date_settings_input_spec.rb

@@ -1,8 +1,9 @@
 require "rails_helper"
 
 RSpec.describe Pages::DateSettingsInput, type: :model do
+  let(:form) { create :form }
   let(:date_settings_input) { build :date_settings_input, draft_question: }
-  let(:draft_question) { build :draft_question, answer_type: "date", form_id: 1 }
+  let(:draft_question) { build :draft_question, answer_type: "date", form_id: form.id }
 
   it "has a valid factory" do
     expect(date_settings_input).to be_valid

spec/input_objects/pages/guidance_input_spec.rb

@@ -1,8 +1,9 @@
 require "rails_helper"
 
 RSpec.describe Pages::GuidanceInput, type: :model do
+  let(:form) { create :form }
   let(:guidance_input) { build :guidance_input, page_heading:, guidance_markdown:, draft_question: }
-  let(:draft_question) { build :draft_question, page_heading:, guidance_markdown: }
+  let(:draft_question) { build :draft_question, page_heading:, guidance_markdown:, form_id: form.id }
   let(:page_heading) { "New guidance heading" }
   let(:guidance_markdown) { "## Level heading 2" }
 

spec/input_objects/pages/name_settings_input_spec.rb

@@ -1,8 +1,9 @@
 require "rails_helper"
 
 RSpec.describe Pages::NameSettingsInput, type: :model do
+  let(:form) { create :form }
   let(:name_settings_input) { build :name_settings_input, draft_question: }
-  let(:draft_question) { build :draft_question, answer_type: "name", form_id: 1 }
+  let(:draft_question) { build :draft_question, answer_type: "name", form_id: form.id }
 
   it "has a valid factory" do
     expect(name_settings_input).to be_valid

spec/input_objects/pages/question_input_spec.rb

@@ -1,8 +1,9 @@
 require "rails_helper"
 
 RSpec.describe Pages::QuestionInput, type: :model do
+  let(:form) { create :form }
   let(:question_input) { build :question_input, answer_type:, question_text:, draft_question:, is_optional:, is_repeatable: }
-  let(:draft_question) { build :draft_question, question_text: }
+  let(:draft_question) { build :draft_question, question_text:, form_id: form.id }
   let(:question_text) { "What is your full name?" }
   let(:is_optional) { "false" }
   let(:is_repeatable) { "false" }
@@ -78,7 +79,7 @@
     end
 
     describe "#hint_text" do
-      let(:question_input) { build :question_input, hint_text: }
+      let(:question_input) { build :question_input, hint_text:, draft_question: }
       let(:hint_text) { "Enter your full name as it appears in your passport" }
 
       it "is valid if hint text is empty" do
@@ -113,7 +114,7 @@
     end
 
     describe "#is_optional" do
-      let(:question_input) { build :question_input, is_optional: }
+      let(:question_input) { build :question_input, is_optional:, draft_question: }
 
       context "when is_optional is nil" do
         let(:is_optional) { nil }
@@ -156,7 +157,7 @@
     end
 
     describe "#is_repeatable" do
-      let(:question_input) { build :question_input, is_repeatable: }
+      let(:question_input) { build :question_input, is_repeatable:, draft_question: }
 
       context "and is_repeatable is nil" do
         let(:is_repeatable) { nil }
@@ -209,7 +210,7 @@
     describe "selection options" do
       let(:selection_options) { (1..31).to_a.map { |i| { name: i.to_s } } }
       let(:only_one_option) { "false" }
-      let(:draft_question) { build :selection_draft_question, answer_settings: { selection_options:, only_one_option: } }
+      let(:draft_question) { build :selection_draft_question, answer_settings: { selection_options:, only_one_option: }, form_id: form.id }
 
       context "when only_one_option is true" do
         let(:only_one_option) { "true" }
@@ -240,7 +241,7 @@
       end
 
       context "when answer type is not selection" do
-        let(:draft_question) { build :name_draft_question, answer_settings: { selection_options:, only_one_option: } }
+        let(:draft_question) { build :name_draft_question, answer_settings: { selection_options:, only_one_option: }, form_id: form.id }
 
         it "is valid" do
           expect(question_input).to be_valid

spec/input_objects/pages/question_text_input_spec.rb

@@ -1,8 +1,9 @@
 require "rails_helper"
 
 RSpec.describe Pages::QuestionTextInput, type: :model do
+  let(:form) { create :form }
   let(:question_text_input) { build :question_text_input, draft_question: }
-  let(:draft_question) { build :draft_question, answer_type: "selection", form_id: 1 }
+  let(:draft_question) { build :draft_question, answer_type: "selection", form_id: form.id }
 
   it "has a valid factory" do
     expect(question_text_input).to be_valid

spec/input_objects/pages/selection/bulk_options_input_spec.rb

@@ -1,9 +1,10 @@
 require "rails_helper"
 
 RSpec.describe Pages::Selection::BulkOptionsInput, type: :model do
+  let(:form) { create :form }
   let(:bulk_options_input) { build :bulk_options_input, draft_question: }
   let(:only_one_option) { "true" }
-  let(:draft_question) { build :draft_question, answer_type: "selection", answer_settings: { only_one_option: } }
+  let(:draft_question) { create :draft_question, answer_type: "selection", answer_settings: { only_one_option: }, form_id: form.id }
 
   it "has a valid factory" do
     expect(bulk_options_input).to be_valid
@@ -75,7 +76,7 @@
     end
 
     context "when include_none_of_the_above is not 'true' or 'false'" do
-      let(:bulk_options_input) { build :bulk_options_input, include_none_of_the_above: nil }
+      let(:bulk_options_input) { build :bulk_options_input, include_none_of_the_above: nil, draft_question: }
 
       it "is invalid" do
         error_message = I18n.t("activemodel.errors.models.pages/selection/bulk_options_input.attributes.include_none_of_the_above.inclusion")

spec/input_objects/pages/selection/options_input_spec.rb

@@ -1,8 +1,9 @@
 require "rails_helper"
 
 RSpec.describe Pages::Selection::OptionsInput do
+  let(:form) { create :form }
   let(:only_one_option) { "true" }
-  let(:draft_question) { build :draft_question, answer_type: "selection", answer_settings: { only_one_option: } }
+  let(:draft_question) { build :draft_question, answer_type: "selection", answer_settings: { only_one_option: }, form_id: form.id }
   let(:selection_options) { [{ name: "option 1" }, { name: "option 2" }] }
 
   describe "validations" do

spec/input_objects/pages/selection/type_input_spec.rb

@@ -3,7 +3,9 @@
 RSpec.describe Pages::Selection::TypeInput do
   subject(:input) { described_class.new(draft_question:, only_one_option:) }
 
-  let(:draft_question) { build :draft_question, answer_type: "selection" }
+  let(:form) { create :form }
+
+  let(:draft_question) { build :draft_question, answer_type: "selection", form_id: form.id }
   let(:only_one_option) { nil }
 
   describe "validations" do

spec/input_objects/pages/text_settings_input_spec.rb

@@ -1,8 +1,9 @@
 require "rails_helper"
 
 RSpec.describe Pages::TextSettingsInput, type: :model do
+  let(:form) { create :form }
   let(:text_settings_input) { build :text_settings_input, draft_question: }
-  let(:draft_question) { build :draft_question, answer_type: "text", form_id: 1 }
+  let(:draft_question) { build :draft_question, answer_type: "text", form_id: form.id }
 
   it "has a valid factory" do
     expect(text_settings_input).to be_valid