Pass form_name to analytics in draft_question inputs

Passes the form_name from the draft question to the analytics event for
any input that includes a draft_question attribute.

This fixes an issue where some inputs weren't including the form name in
the analytics event.

Author: DavidBiddle

app/input_objects/base_input.rb

@@ -8,10 +8,16 @@ class BaseInput
 
   def set_validation_error_logging_attributes
     CurrentLoggingAttributes.validation_errors = errors.map { |error| "#{error.attribute}: #{error.type}" } if errors.any?
-    form_name = form.name if defined?(form) && form.present?
 
     errors.each do |error|
       AnalyticsService.track_validation_errors(input_object_name: self.class.name, field: error.attribute, error_type: error.type, form_name:)
     end
   end
+
+  def form_name
+    return form.name if defined?(form) && form.present?
+    return draft_question.form_name if defined?(draft_question) && draft_question.present?
+
+    nil
+  end
 end

spec/input_objects/base_input_spec.rb

@@ -14,6 +14,13 @@ class TestInputWithForm < BaseInput
   validates :email, format: { with: /.*@.*/, message: "must be a valid email address" }
 end
 
+class TestInputWithDraftQuestion < BaseInput
+  attr_accessor :name, :email, :draft_question
+
+  validates :name, presence: true
+  validates :email, format: { with: /.*@.*/, message: "must be a valid email address" }
+end
+
 RSpec.describe BaseInput do
   describe "validation error logging" do
     let(:analytics_service) { class_double(AnalyticsService).as_stubbed_const }
@@ -96,6 +103,39 @@ class TestInputWithForm < BaseInput
           end
         end
       end
+
+      context "when the draft_question is defined in the input" do
+        let(:input) { TestInputWithDraftQuestion.new }
+
+        context "when the draft_question is nil" do
+          it "does not include a form name in the validation errors" do
+            input.valid?
+
+            expect(analytics_service).to have_received(:track_validation_errors)
+              .with(input_object_name: "TestInputWithDraftQuestion", form_name: nil, field: :name, error_type: :blank)
+
+            expect(analytics_service).to have_received(:track_validation_errors)
+              .with(input_object_name: "TestInputWithDraftQuestion", form_name: nil, field: :email, error_type: :invalid)
+          end
+        end
+
+        context "when the draft_question is present" do
+          let(:form_name) { "Apply for a juggling licence" }
+          let(:form) { create :form, name: form_name }
+          let(:draft_question) { build :draft_question, form_id: form.id }
+          let(:input) { TestInputWithDraftQuestion.new(draft_question:) }
+
+          it "includes the form name in the validation errors" do
+            input.valid?
+
+            expect(analytics_service).to have_received(:track_validation_errors)
+              .with(input_object_name: "TestInputWithDraftQuestion", form_name:, field: :name, error_type: :blank)
+
+            expect(analytics_service).to have_received(:track_validation_errors)
+              .with(input_object_name: "TestInputWithDraftQuestion", form_name:, field: :email, error_type: :invalid)
+          end
+        end
+      end
     end
   end
 end