Skip to content

Conversation

@storopoli
Copy link
Member

Description

backport of #934.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added (where necessary) tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

STR-1581

* fix: change all taproot sighashes to Default

- we save 1 byte

* fix(l1tx): robust parsing of taproot signatures
@storopoli storopoli self-assigned this Jul 16, 2025
@storopoli storopoli requested a review from a team as a code owner July 16, 2025 15:59
@storopoli storopoli requested review from a team as code owners July 16, 2025 15:59
@codecov
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (releases/0.2.0@dbae33a). Learn more about missing BASE report.

@@                Coverage Diff                @@
##             releases/0.2.0     #939   +/-   ##
=================================================
  Coverage                  ?   52.81%           
=================================================
  Files                     ?      302           
  Lines                     ?    33404           
  Branches                  ?        0           
=================================================
  Hits                      ?    17642           
  Misses                    ?    15762           
  Partials                  ?        0           
Files with missing lines Coverage Δ
crates/key-derivation/src/operator.rs 89.19% <100.00%> (ø)
crates/l1tx/src/deposit/deposit_tx.rs 99.26% <100.00%> (ø)
crates/test-utils/src/bitcoin.rs 93.80% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@storopoli storopoli enabled auto-merge (squash) July 16, 2025 16:26
@github-actions
Copy link
Contributor

Commit: 57ec95e

SP1 Execution Results

program cycles success
Bitcoin Blockspace 71,244
EVM EE STF 278,136
CL STF 166,085
Checkpoint 4,217

@storopoli storopoli merged commit c8bdf5b into releases/0.2.0 Jul 17, 2025
23 checks passed
@storopoli storopoli deleted the backport/934 branch July 17, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants