Wrap multistep L2Db operations in transactions #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bewakes
previously approved these changes
Jul 8, 2024
delbonis
requested changes
Jul 8, 2024
Contributor
delbonis
left a comment
delbonis
left a comment
There was a problem hiding this comment.
Looks great except for a couple nits. But we should really figure out the dependent reference thing before we merge this.
sapinb
force-pushed
the
feature/l2-db-transaction
branch
from
b31f6d0 to
1e9a80a
Compare
1 task
sapinb
force-pushed
the
feature/l2-db-transaction
branch
2 times, most recently
from
414d6f1 to
99cdfb1
Compare
Contributor
|
This all looks pretty good as soon as we figure out the url thing. |
delbonis
previously approved these changes
Jul 17, 2024
Contributor
|
What's blocking this? |
update rockbound target to new branch
add conversion from TransactionError to DbError
sapinb
force-pushed
the
feature/l2-db-transaction
branch
from
99cdfb1 to
cacc6d5
Compare
Contributor
Author
@delbonis Was waiting to make the rockbound repo public. Have created a new public fork of rockbound and this is now unblocked |
|
The author of this PR, sapinb, is not an activated member of this organization on Codecov. |
bewakes
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
put_block_dataanddel_block_dataimplementations for L2Db in transactionsresolves #85
related PR:
alpenlabs/rockbound#1alpenlabs/rockbound#2