feat(mmr): inital MMR rewrite complete #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bewakes
requested changes
Jun 24, 2024
delbonis
requested changes
Jun 24, 2024
There was a problem hiding this comment.
There's a few issues here. I should have been more clear that the "chunk" concept was specific to the original application the provided code was used for and that we just need to talk about it in terms of leafs as hashes. But the main issue we really gotta resolve is the excessive allocations, some bookkeeping, and module layout.
added 2 commits
June 25, 2024 17:07
- Concept of chunk is removed - H type used instead of Sha256 for trait that uses Digest - new verify function
delbonis
requested changes
Jun 25, 2024
…emove hash_leaves function, \n - remove redundant prooflen from MerkleHash
delbonis
requested changes
Jun 27, 2024
crates/util/mmr/src/lib.rs
Outdated
Comment on lines
220
to
239
| /// verifies if the hash of the element at particular index is present as a proof | ||
| pub fn verify(&self,proof: &MerkleProof<H>,hash: MerkleHash) -> Result<bool, MerkleError> { | ||
| if proof.index as usize>= self.num as usize{ | ||
| return Err(MerkleError::IndexOutOfBounds); | ||
| } | ||
|
|
||
| return Ok(proof.proof_verify(self, hash)); | ||
| } | ||
|
|
||
| /// constructs a MerkleProof and then verifies it | ||
| pub fn verify_with_cohashes(&self, index: u64,hash: MerkleHash, cohashes: Vec<MerkleHash>) -> Result<bool, MerkleError> { | ||
| let proof: MerkleProof<H> = MerkleProof { | ||
| prooflen: cohashes.len(), | ||
| cohashes, | ||
| index, | ||
| hasher: PhantomData, | ||
| }; | ||
|
|
||
| self.verify(&proof, hash) | ||
| } |
There was a problem hiding this comment.
not new but something like this yes
|
I think this is in a good position now. We can roll with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first rewrite of MMR based on https://codeberg.org/treyd/supermerkle.
Closes #74