-
Notifications
You must be signed in to change notification settings - Fork 21
Handle L1Block Sync Events #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## master #197 +/- ##
==========================================
+ Coverage 51.06% 53.62% +2.55%
==========================================
Files 85 86 +1
Lines 7439 7596 +157
==========================================
+ Hits 3799 4073 +274
+ Misses 3640 3523 -117
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far. The math in the client transition bookkeeping is a bit roundabout but it looks correct.
4c1a405 to
431a5c7
Compare
431a5c7 to
0ea9d18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good!
Type of Change
Checklist
Related Issues
Closes #144
Closes #145