-
Notifications
You must be signed in to change notification settings - Fork 21
duty_executor: figure out which blocks are newly finalized #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, just the weird thing that would be nice to clean up. If it's too much trouble to change I think it can be merged.
d8bea9d to
2502589
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## master #164 +/- ##
==========================================
+ Coverage 53.62% 53.85% +0.23%
==========================================
Files 86 86
Lines 7596 7687 +91
==========================================
+ Hits 4073 4140 +67
- Misses 3523 3547 +24
|
d89f3e8 to
6af2468
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor cleanup but otherwise looks good I think. I'll DM about the bookkeeping I mentioned in the previous review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I didn't think that would be this clean.
d59f55f to
71e93cf
Compare
71e93cf to
c76e73d
Compare
Resolves #90