-
Notifications
You must be signed in to change notification settings - Fork 449
Deletes vllm_utils.py and renames vllm_utils3.py to vllm_utils.py. #1078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
finbarrtimbers
wants to merge
380
commits into
main
Choose a base branch
from
refactor-vllm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…list[CompletionOutput].
* uses uni * undid multipprocessing * Cleaned up logging (#1069) * Fix missing logprobs accumulation in tool-using requests When tools are enabled, process_request_async accumulates tokens across multiple tool-calling iterations but was discarding logprobs by setting them to None. This caused crashes when the downstream code tried to extract logprobs from the CompletionOutput. Fixed by: - Adding accumulated_logprobs list to track logprobs across iterations - Accumulating output.logprobs for model-generated tokens - Creating mock logprob objects with NaN values for tool output tokens - Passing accumulated_logprobs to CompletionOutput instead of None 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * Fixed tool trigger check * Updated code --------- Co-authored-by: Claude <[email protected]>
Blocked by #1016. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vllm_utils.py
was not used anywhere.