Skip to content

Make the build script make everything lowercase #1074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 365 commits into from
Oct 17, 2025
Merged

Make the build script make everything lowercase #1074

merged 365 commits into from
Oct 17, 2025

Conversation

@finbarrtimbers
Copy link
Collaborator

@finbarrtimbers finbarrtimbers commented Oct 10, 2025 •
edited
Loading

Otherwise, when running in an old commit, we get errors.

Ran the debug script: Beaker.

@finbarrtimbers
Now, processing persists across calls to process_from_queue
2e4adbf
@finbarrtimbers
Added local tool script
7c8046d
@finbarrtimbers
Updated code
96dd3ed
@finbarrtimbers
Lots of changes
4902547
@finbarrtimbers
Fixed exit condition
94cca19
@finbarrtimbers
Cleaned up code
aca6420
@finbarrtimbers
Added a fix to make sure we don't process a request until all tool fu…
e4b607d 
…tures are complete.
@finbarrtimbers
Fixed bug where we were accidentally adding unfinished requests to re…
c94de62 
…quest_outputs.
@finbarrtimbers
Updated script so we can't launch experiments with a dirty repo.
7f2ecb4
@finbarrtimbers
fixed bug
65c4746
@finbarrtimbers
mdofied script
42d6b4c
@finbarrtimbers
Attempt at making the flow correct
6333ab9
@finbarrtimbers
Added additional tracking.
7da1333
@finbarrtimbers
Added more logging
17185bc
@finbarrtimbers
Fixed bug that was incorrectly considering a request complete.
a087643
@finbarrtimbers
Checks for active vllm continuations
9dd6c77
@finbarrtimbers
Fixed sub-requests
3a1dfa4
@finbarrtimbers
Added additional assertions to track bug down.
5f062da
@finbarrtimbers
Updated code to add validation
962e68e
@finbarrtimbers
Added more validation.
0a16931
@finbarrtimbers
Fixed error in validation
6a6f0f6
@finbarrtimbers
Added more validation.
bef44d5
@finbarrtimbers
Fixed error in validation.
c2801c6
@finbarrtimbers
Added more validation.
abc18f5
@finbarrtimbers
Fixed validations.
a2be83d
@finbarrtimbers
updated validation.
331b2ae
@finbarrtimbers
Fixed a bug with processing. Added a function to handle finishing a r…
6f3ee34 
…equest.
@finbarrtimbers
Moved where we call validation to be in a more appropriate place.
5e3ea7b
@finbarrtimbers
Fixed validation to be more comprehensive.
8e438c9
@finbarrtimbers
Fixed bug where we were passing a RequestOutput object rather than a …
a5b70d3 
…list[CompletionOutput].
@finbarrtimbers
Add detailed logging after tool execution to trace iteration hang
d1f0a50
@finbarrtimbers
Add fine-grained logging to debug model config access hang
b599b15
@finbarrtimbers
Add detailed logging to debug prompt concatenation hang
08db870
@finbarrtimbers
Cache prompt_token_ids to avoid hang when accessing TokensPrompt prop…
a59d9f0 
…erty
@finbarrtimbers
Fix undefined variable in assert_threaded_actor
3675f06
@finbarrtimbers
Updated code
9a9a5c0
@finbarrtimbers
Set inflight false
cafc0d2
@finbarrtimbers
Fixed duplicate flag
49724e8
@finbarrtimbers
Simplified significantly
7a49068
@finbarrtimbers
Removed logs
be451be
@finbarrtimbers
Simplified threading model
2cf5750
@finbarrtimbers
Added handling for inflight_updates
025fb40
@finbarrtimbers
Inlined generate_one_completion
97610cd
@finbarrtimbers
Clean up
10f9e1a
@finbarrtimbers
More clean up
f32879f
@finbarrtimbers
Set inflight to true
cb10def
@finbarrtimbers
Cleaned up code.
9708fc4
@finbarrtimbers
lots of cleanup
fff7d87
@finbarrtimbers
Major refactor
03db661
@finbarrtimbers
More PR cleanup
e0a0960
@finbarrtimbers
Merge branch 'main' into async-engine
60897fe
@finbarrtimbers
Fixed code
2f592b5
@finbarrtimbers
Updated script
434bbf0
@finbarrtimbers
Cleaned up PR
d4e758f
@finbarrtimbers finbarrtimbers marked this pull request as ready for review October 17, 2025 21:17
@finbarrtimbers finbarrtimbers added this pull request to the merge queue Oct 17, 2025
Merged via the queue into main with commit 86d33b2 Oct 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saurabh111233212 saurabh111233212 saurabh111233212 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@finbarrtimbers @saurabh111233212