Skip to content

Conversation

@aman-17
Copy link
Contributor

@aman-17 aman-17 commented May 23, 2025

Added Docker workflow.

@aman-17 aman-17 requested a review from Copilot May 23, 2025 19:51
@aman-17 aman-17 merged commit 78ea21a into main May 23, 2025
7 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a GitHub Actions workflow to build and push Docker images, with custom version inputs, tag calculations, and cleanup steps

  • Introduces push and workflow_dispatch triggers with optional version input
  • Calculates and overrides Docker image tags via shell logic and docker/metadata-action
  • Adds pre- and post-build disk cleanup, enforces no-cache, and outputs registry metadata
Comments suppressed due to low confidence (4)

.github/workflows/docker-build.yml:8

  • Remove the stray hyphen on line 1 to avoid YAML parsing errors.
-

.github/workflows/docker-build.yml:30

  • There’s an extra hyphen before the permissions block that may cause YAML syntax issues; remove it.
-

.github/workflows/docker-build.yml:110

  • Verify that outputs: type=registry is a valid parameter for docker/build-push-action@v5; an unrecognized input here could cause the action to fail.
outputs: type=registry

.github/workflows/docker-build.yml:111

  • [nitpick] Disabling the build cache with no-cache: true will slow down CI builds; consider re-enabling caching to improve performance.
no-cache: true

/usr/local/lib/android \
/opt/ghc \
/opt/hostedtoolcache/CodeQL
sudo docker system prune -af
Copy link

Copilot AI May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Running a full docker system prune -af may remove images needed by later steps; consider scoping the cleanup or using an official cache/cleanup action.

Suggested change
sudo docker system prune -af
sudo docker system prune --filter "dangling=true"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants