Skip to content

Fix example usage documentation #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2025
Merged

Fix example usage documentation #819

merged 2 commits into from
May 22, 2025

Conversation

ved1beta
Copy link
Contributor

@ved1beta ved1beta commented Apr 3, 2025

Fix example usage documentation in convert_olmo_to_hf_new.py

  • Correct the script path from src/transformers/models/olmo/convert_olmo_weights_to_hf.py to scripts/convert_olmo_to_hf_new.py
  • Remove non-existent --model_size parameter from the example
  • Ensure example matches actual implementation parameters

Fixes #815

@aman-17 aman-17 merged commit 90e09bd into allenai:main May 22, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkgr dirkgr dirkgr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scripts/convert_olmo_to_hf_new.py example usage mistakes
3 participants
@ved1beta @dirkgr @aman-17