-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Dogfood pmd plugin #466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Dogfood pmd plugin #466
Conversation
|
I can also set up a CI job (Travis/CircleCI/Appveyor, etc.) if necessary. |
This commit applies pmd plugin and rules to p3c-pmd project and fixes two violations.
p3c-pmd/pom.xml
Outdated
<version>3.8</version> | ||
<configuration> | ||
<sourceEncoding>${project.build.sourceEncoding}</sourceEncoding> | ||
<targetJdk>1.8</targetJdk> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is good, please advise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
你好,目前我们的插件是从JDK1.7版本开始支持。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的。根据https://maven.apache.org/plugins/maven-pmd-plugin/examples/targetJdk.html 的建议,将这个值改为:${maven.compiler.target}
<version>3.8</version> | ||
<configuration> | ||
<sourceEncoding>${project.build.sourceEncoding}</sourceEncoding> | ||
<targetJdk>${maven.compiler.target}</targetJdk> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
还需要在<properties>里加上maven.compiler.target这个属性吧?
<maven.compiler.source>1.7</maven.compiler.source>
<maven.compiler.target>1.7</maven.compiler.target>
下面maven-compiler-plugin里也统一改成这种形式。
你好,插件最新版已经更新 你那边帮忙看看是否有需要改进的,因为改动较大,所以你本次pr可能不再适用了,十分抱歉 |
suggest do NEVER do clinic dependency with a specific version.
or even:
|
Context
It's not convincing if p3c project doesn't dogfood its own pmd plugin. This PR applies pmd plugin and rules to p3c-pmd project and fixes two violations.