add SuspenseWrappers to Runtime #7131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
这两个 case 具体的场景是什么，特别是强制修改 APP_CONFIG 的逻辑，正常情况下 应该都是在入口做处理 |
riopop
force-pushed
the
feat/suspense-wrapper
branch
from
4d1b951 to
b35bcbe
Compare
riopop
changed the title
Contributor
Author
已修改，仅保留 addSuspenseWrapper API。一般用于暴露给 ice runtime 插件消费，更细粒度的感知和控制 Suspense 模块，便于开发插件，通用的处理异常边界/采集 Suspense 性能数据等。 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds dynamic Suspense wrapper support to the runtime, allowing applications to register Suspense wrappers that can be composed around Suspense-enabled components.
- Add
SuspenseWrappersconfiguration to the Runtime and AppContext types - Enhance
withSuspenseHOC to compose multiple Suspense wrappers around components - Provide new
addSuspenseWrapperAPI for registering wrappers
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/runtime/src/types.ts | Add SuspenseWrapper types and configuration interfaces |
| packages/runtime/src/runtime.tsx | Implement SuspenseWrapper storage and registration API |
| packages/runtime/src/Suspense.tsx | Enhance withSuspense to compose registered wrappers |
| .changeset/ten-paws-sort.md | Add changeset for patch release |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ClarkXia
approved these changes
Aug 21, 2025
answershuto
approved these changes
Aug 22, 2025
ClarkXia
added a commit
that referenced
this pull request
Aug 27, 2025
* feat: add SuspenseWrappers to Runtime (#7131) * feat: add SuspenseWrappers to Runtime * chore(runtime): format code * fix(runtime): Apply suggestions from code review Co-authored-by: Copilot <[email protected]> * fix(runtime): remove redundant composeSuspenseWrappers function --------- Co-authored-by: Copilot <[email protected]> * chore: update versions (#7133) * chore: update versions * Remove 3.6.6 entry from CHANGELOG Removed version 3.6.6 entry from CHANGELOG. * Update package.json * Update CHANGELOG.md * Downgrade version from 1.1.7 to 1.1.6 * Remove changelog entry for version 1.2.7 Removed version 1.2.7 entry from changelog. * Update package.json * Update CHANGELOG.md * Update package.json * Update package.json * Update package.json * Update pnpm-lock.yaml --------- Co-authored-by: Mixiu <[email protected]> Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add SuspenseWrappers to Runtime
SuspenseWrapperstoRuntimefor dynamic Suspense wrapperswithSuspenseto compose multiple wrappers