Skip to content

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Apr 23, 2024

Ⅰ. Describe what this PR did

  1. Allow Wasm plugins to use X-ENVOY-ORIGINAL-HOST header to store the host header by update.
  2. Use the same access log settings in the envoy.yaml file generated by hgctl plugin test create command.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CH3CHO CH3CHO merged commit a592b2b into alibaba:main Apr 23, 2024
@CH3CHO CH3CHO deleted the feat/access-log-original-host branch April 23, 2024 02:50
VinceCui pushed a commit to VinceCui/higress that referenced this pull request May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants