Skip to content

Conversation

sjcsjc123
Copy link
Collaborator

Ⅰ. Describe what this PR did

添加go语言实现的sni-misdirect插件

Ⅱ. Does this pull request fix one issue?

fixes: #595

Ⅲ. Why don't you add test cases (unit test/integration test)?

提供部分e2e测试样例

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

目前e2e测试框架暂不支持发送http2请求

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (10f5267) 33.91% compared to head (57930b5) 34.02%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #720      +/-   ##
==========================================
+ Coverage   33.91%   34.02%   +0.11%     
==========================================
  Files          78       78              
  Lines       11199    11199              
==========================================
+ Hits         3798     3811      +13     
+ Misses       7107     7096      -11     
+ Partials      294      292       -2     

see 2 files with indirect coverage changes

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@johnlanni johnlanni merged commit c647ab3 into alibaba:main Dec 25, 2023
@sjcsjc123 sjcsjc123 deleted the wasm-sni-misdirect branch January 14, 2024 06:45
VinceCui pushed a commit to VinceCui/higress that referenced this pull request May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the Golang version of the existing CPP Wasm plugin: sni-misdirect
3 participants