Skip to content

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Jan 3, 2025

Ⅰ. Describe what this PR did

Enlarge the default retry timeout in ai-proxy since retry requests are not streaming.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@CH3CHO CH3CHO requested a review from johnlanni January 3, 2025 03:06
@CH3CHO CH3CHO requested review from cr7258 and rinfx as code owners January 3, 2025 03:06
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.42%. Comparing base (ef31e09) to head (e76fade).
Report is 247 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1640      +/-   ##
==========================================
+ Coverage   35.91%   43.42%   +7.51%     
==========================================
  Files          69       76       +7     
  Lines       11576    12325     +749     
==========================================
+ Hits         4157     5352    +1195     
+ Misses       7104     6636     -468     
- Partials      315      337      +22     

see 69 files with indirect coverage changes

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 187a7b5 into alibaba:main Jan 3, 2025
11 checks passed
@CH3CHO CH3CHO deleted the fix/ai-proxy-retry-timeout branch January 3, 2025 03:20
VinceCui pushed a commit to VinceCui/higress that referenced this pull request May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants