Skip to content

[Pick][0.9 to main] | fix iovector not checking size before extracting continuous buffer (#1010) (#1011) (#1013) #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2025
Merged

[Pick][0.9 to main] | fix iovector not checking size before extracting continuous buffer (#1010) (#1011) (#1013) #1014

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions common/iovector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,12 +535,15 @@ class iovector
update(va);
return ptr;
}

if (va.sum() < bytes) {
return nullptr;
}

auto buf = do_malloc(bytes);
auto ret = extract_front(bytes, buf);
return ret == bytes ?
buf :
nullptr;
if (buf) {
extract_front(bytes, buf);
}
return buf;
}

// try to extract `bytes` bytes from the back
Expand Down Expand Up @@ -626,12 +629,15 @@ class iovector
update(va);
return ptr;
}
if (va.sum() < bytes) {
return nullptr;
}

auto buf = do_malloc(bytes);
auto ret = extract_back(bytes, buf);
return ret == bytes ?
buf :
nullptr;
if (buf) {
extract_back(bytes, buf);
}
return buf;
}

// copy data to a buffer of `size` bytes,
Expand Down
Loading