Skip to content

fix iovector not checking size before extracting continuous buffer #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 9, 2025
Merged

fix iovector not checking size before extracting continuous buffer #1010

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
307911c
fix iovec not checking size before extracting continuous buffer
NewbieOrange Oct 2, 2025
e52a6da
Update iovector.h
NewbieOrange Oct 9, 2025
00f7be3
Update iovector.h
NewbieOrange Oct 9, 2025
f5df5d2
Update iovector.h
NewbieOrange Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions common/iovector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,12 +527,13 @@ class iovector
update(va);
return ptr;
}

if (va.sum() < bytes) {
return nullptr;
}

auto buf = do_malloc(bytes);
auto ret = extract_front(bytes, buf);
return ret == bytes ?
buf :
nullptr;
extract_front(bytes, buf);
return buf;
}

// try to extract `bytes` bytes from the back
Expand Down Expand Up @@ -618,12 +619,13 @@ class iovector
update(va);
return ptr;
}
if (va.sum() < bytes) {
return nullptr;
}

auto buf = do_malloc(bytes);
auto ret = extract_back(bytes, buf);
return ret == bytes ?
buf :
nullptr;
extract_back(bytes, buf);
return buf;
}

// copy data to a buffer of size `size`,
Expand Down Expand Up @@ -1080,4 +1082,4 @@ class SmartCloneIOV

#undef IF_ASSERT_RETURN

#pragma GCC diagnostic pop
#pragma GCC diagnostic pop
Loading