iovector/_view.memcpy_from/to() do not consume the buffers #1008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coldwings
approved these changes
Sep 29, 2025
beef9999
approved these changes
Oct 9, 2025
lihuiba
force-pushed
the
iov_memcpy
branch
3 times, most recently
from
d8ee40c to
cb29ed0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior iovector/_view.memcpy_from/to() would consume the bytes in source after copying to destination for some of the overloadings. This semantics is counter-intuitive and error-prone, so we decide to make a breaking change to make them copy-only (not consuming the bytes in the source).