Skip to content

Infrastructure: Add setup.py check to circle ci #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jan 11, 2023
Merged

Infrastructure: Add setup.py check to circle ci #427

merged 14 commits into from
Jan 11, 2023

Conversation

@algochoi
Copy link
Contributor

@algochoi algochoi commented Dec 23, 2022 •
edited
Loading

This PR adds a check to see if setup.py is well-formed. It also removes the v prefix from the version, as it does not seem necessary (related change) and generates a user warning:

dist.py:487: UserWarning: Normalizing 'v1.20.2' to '1.20.2'
  warnings.warn(tmpl.format(**locals()))

Closes #409

@algochoi algochoi marked this pull request as ready for review December 27, 2022 16:54
@algochoi algochoi requested a review from tzaffi December 27, 2022 17:48
michaeldiamant
michaeldiamant reviewed Jan 9, 2023
View reviewed changes
michaeldiamant
michaeldiamant reviewed Jan 10, 2023
View reviewed changes
@algochoi @michaeldiamant
Update .circleci/config.yml
6113312 
Co-authored-by: Michael Diamant <[email protected]>
michaeldiamant
michaeldiamant approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@michaeldiamant michaeldiamant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@algochoi Thanks for coming up with a solution here so that we avoid regressions!

@michaeldiamant michaeldiamant mentioned this pull request Jan 11, 2023
Merged
@algochoi algochoi merged commit 2e1c00d into develop Jan 11, 2023
@algochoi algochoi deleted the setup-check branch January 11, 2023 15:37
@algobarb algobarb mentioned this pull request Mar 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tzaffi tzaffi Awaiting requested review from tzaffi

1 more reviewer

@michaeldiamant michaeldiamant michaeldiamant approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI: Check for sdist metadata warnings

3 participants

@algochoi @michaeldiamant