Skip to content

Conversation

@aldur
Copy link
Contributor

@aldur aldur commented Feb 14, 2022

Tentatively add the ABI package and atomic_transaction_composer docs to Sphinx.

I have used an ugly command line to generate the abi files; might have missed something.
Also, first time using sphinx :)

@aldur
Copy link
Contributor Author

aldur commented Feb 14, 2022

If merged, will close #281.

@aldur aldur requested a review from barnjamin February 14, 2022 13:56
aldur added a commit that referenced this pull request Feb 14, 2022
Was getting the following error from `mypy`:
> py-algorand-sdk/algosdk/atomic_transaction_composer.py|693 col 23-28 error| Module cannot be used as a type

Also, this was creating trouble when generating documentation (see #289)
@barnjamin barnjamin requested a review from algochoi February 14, 2022 14:34
Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried running make html and failed multiple times even after re-installing requirements multiple times so I can't really review it or give meaningful comments :(

Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great :shipit:

Also many thanks for adding sphinx==4.0.1 as other versions do not seem to cooperate with the doc builds 😵‍💫

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants