Skip to content

Add requirement to fetch behave source code and update readme #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 8, 2021
Merged

Add requirement to fetch behave source code and update readme #262

merged 3 commits into from
Dec 8, 2021

Conversation

@algochoi
Copy link
Contributor

@algochoi algochoi commented Dec 7, 2021

This PR makes a README change to add details to the development section and specify the requirements.txt to fetch the latest behave for tag support.

Thanks to @barnjamin for this suggestion 😃

@algochoi algochoi requested a review from barnjamin December 7, 2021 16:41
barnjamin
barnjamin approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@barnjamin barnjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

jasonpaulos
jasonpaulos reviewed Dec 7, 2021
View reviewed changes
Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's probably best to specify dependencies only in one place, could also you modify line 10 of Dockerfile to use pip install -r requirements.txt -q instead?

@algochoi algochoi merged commit fe5af4c into develop Dec 8, 2021
@algochoi algochoi deleted the test-suite-update branch December 8, 2021 16:49
@egieseke egieseke mentioned this pull request Jan 3, 2022
Merged
@algobarb algobarb mentioned this pull request Jan 14, 2022
Merged
aldur pushed a commit that referenced this pull request Feb 8, 2022
@algochoi @aldur
Add requirement to fetch behave source code and update readme (#262)
8da3ffd 
* Add requirement to fetch behave source code and update readme

* Simplify tests section

* Change dockerfile to fetch requirements.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@barnjamin barnjamin barnjamin approved these changes

@jasonpaulos jasonpaulos jasonpaulos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@algochoi @barnjamin @jasonpaulos