tests: add retries to TestCatchpointTrackerWaitNotBlocking #6472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6472 +/- ##
==========================================
- Coverage 51.13% 50.95% -0.19%
==========================================
Files 668 661 -7
Lines 112101 112003 -98
==========================================
- Hits 57327 57066 -261
- Misses 51907 52058 +151
- Partials 2867 2879 +12 ☔ View full report in Codecov by Sentry. |
gmalouf
reviewed
Oct 21, 2025
gmalouf
previously approved these changes
Oct 21, 2025
cce
reviewed
Oct 21, 2025
jannotti
reviewed
Oct 21, 2025
Contributor
jannotti
left a comment
jannotti
left a comment
There was a problem hiding this comment.
Agree that you might as well wait a little longer that 1ms.
jannotti
approved these changes
Oct 21, 2025
gmalouf
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TestCatchpointTrackerWaitNotBlocking started failing after migration to GH Actions. Failure example: https://github.com/algorand/go-algorand/actions/runs/18669344175/job/53227121869?pr=6469
Fixed by adding retries into assertion loop in order to give block syncer goroutine to finish flushing blocks.
Test Plan
This is a test change