Skip to content

Conversation

@cce
Copy link
Contributor

@cce cce commented Oct 17, 2025

Summary

Bumps Go version from 1.23 to 1.25.
Related PRs:

Fix go vet warnings preventing tests from compiling/passing due to
https://go.dev/doc/go1.24

  • "The existing printf analyzer now reports a diagnostic for calls of the form fmt.Printf(s), where s is a non-constant format string, with no other arguments. Such calls are nearly always a mistake as the value of s may contain the % symbol; use fmt.Print instead. See #60529."
  • New dead code after panic errors in msgp-generated MaxSize functions

Test Plan

Existing tests should pass

…od tools/block-generator/go.mod tools/x-repo-types/go.mod

gsed -i 's|go1.23.9|go1.25.3|' cmd/partitiontest_linter/go.mod go.mod tools/block-generator/go.mod tools/x-repo-types/go.mod
gsed -i 's|1.23.9|1.25.3|' Dockerfile scripts/get_golang_version.sh
@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.17%. Comparing base (1625da7) to head (f604571).
⚠️ Report is 3 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
cmd/algorelay/commands.go 0.00% 2 Missing ⚠️
cmd/algoh/main.go 0.00% 1 Missing ⚠️
cmd/catchpointdump/file.go 0.00% 1 Missing ⚠️
cmd/tealdbg/cdtSession.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6468      +/-   ##
==========================================
- Coverage   51.13%   46.17%   -4.97%     
==========================================
  Files         668      661       -7     
  Lines      112101   112004      -97     
==========================================
- Hits        57327    51719    -5608     
- Misses      51907    57532    +5625     
+ Partials     2867     2753     -114     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cce cce requested a review from Copilot October 20, 2025 18:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Go toolchain from version 1.23 to 1.25, along with related dependency updates to support the new version.

  • Updates Go version from 1.23.0 to 1.25.0 and toolchain from 1.23.9 to 1.25.3
  • Updates dependencies including go-deadlock, msgp, and various build tools to versions compatible with Go 1.25
  • Includes code generation updates from the new msgp version, which removes unreachable return statements after panic calls

Reviewed Changes

Copilot reviewed 26 out of 29 changed files in this pull request and generated no comments.

Show a summary per file
File Description
go.mod Updates primary module Go version and core dependencies
tools/*/go.mod Updates Go version in tool modules
scripts/get_golang_version.sh Updates build script Go version reference
scripts/buildtools/versions Updates build tool dependency versions
Dockerfile Updates Go version in Docker build
**/msgp_gen.go Auto-generated code changes from new msgp version
tools/debug/logfilter/main.go Simplifies fmt.Fprintf calls to fmt.Fprint
cmd/tealdbg/cdtSession.go Improves error wrapping with %w format
cmd/algorelay/relayCmd.go Fixes makeExitError format string calls
cmd/catchpointdump/file.go Simplifies fmt.Printf to fmt.Print
cmd/algoh/main.go Simplifies fmt.Fprintf to fmt.Fprint
cmd/catchupsrv/tarblocks.go Removes unreachable error return
daemon/kmd/api/api.go Adds --transparent-aliases flag to swagger generation
.github/workflows/reviewdog.yml Updates golangci-lint version and workflow implementation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

jannotti
jannotti previously approved these changes Oct 20, 2025
Copy link
Contributor

@jannotti jannotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. I didn't follow everything going on in CI with linting.

algorandskiy
algorandskiy previously approved these changes Oct 20, 2025
@cce cce dismissed stale reviews from algorandskiy and jannotti via bcb5fed October 20, 2025 19:14
@cce cce requested a review from jannotti October 20, 2025 19:14
@cce cce requested a review from algorandskiy October 20, 2025 19:15
jannotti
jannotti previously approved these changes Oct 20, 2025
Copy link
Contributor

@jannotti jannotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good except for the swagger codegen issue.

algorandskiy
algorandskiy previously approved these changes Oct 20, 2025
@cce cce dismissed stale reviews from algorandskiy and jannotti via f604571 October 21, 2025 18:31
@cce cce merged commit e68b54e into algorand:master Oct 21, 2025
39 checks passed
@cce cce deleted the go1.25 branch October 21, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants