-
Notifications
You must be signed in to change notification settings - Fork 518
build: use Go 1.25 #6468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: use Go 1.25 #6468
Conversation
…od tools/block-generator/go.mod tools/x-repo-types/go.mod gsed -i 's|go1.23.9|go1.25.3|' cmd/partitiontest_linter/go.mod go.mod tools/block-generator/go.mod tools/x-repo-types/go.mod gsed -i 's|1.23.9|1.25.3|' Dockerfile scripts/get_golang_version.sh
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6468 +/- ##
==========================================
- Coverage 51.13% 46.17% -4.97%
==========================================
Files 668 661 -7
Lines 112101 112004 -97
==========================================
- Hits 57327 51719 -5608
- Misses 51907 57532 +5625
+ Partials 2867 2753 -114 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Go toolchain from version 1.23 to 1.25, along with related dependency updates to support the new version.
- Updates Go version from 1.23.0 to 1.25.0 and toolchain from 1.23.9 to 1.25.3
- Updates dependencies including go-deadlock, msgp, and various build tools to versions compatible with Go 1.25
- Includes code generation updates from the new msgp version, which removes unreachable return statements after panic calls
Reviewed Changes
Copilot reviewed 26 out of 29 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates primary module Go version and core dependencies |
| tools/*/go.mod | Updates Go version in tool modules |
| scripts/get_golang_version.sh | Updates build script Go version reference |
| scripts/buildtools/versions | Updates build tool dependency versions |
| Dockerfile | Updates Go version in Docker build |
| **/msgp_gen.go | Auto-generated code changes from new msgp version |
| tools/debug/logfilter/main.go | Simplifies fmt.Fprintf calls to fmt.Fprint |
| cmd/tealdbg/cdtSession.go | Improves error wrapping with %w format |
| cmd/algorelay/relayCmd.go | Fixes makeExitError format string calls |
| cmd/catchpointdump/file.go | Simplifies fmt.Printf to fmt.Print |
| cmd/algoh/main.go | Simplifies fmt.Fprintf to fmt.Fprint |
| cmd/catchupsrv/tarblocks.go | Removes unreachable error return |
| daemon/kmd/api/api.go | Adds --transparent-aliases flag to swagger generation |
| .github/workflows/reviewdog.yml | Updates golangci-lint version and workflow implementation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jannotti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good. I didn't follow everything going on in CI with linting.
jannotti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good except for the swagger codegen issue.
This reverts commit 9f9a5eb.
Summary
Bumps Go version from 1.23 to 1.25.
Related PRs:
Fix go vet warnings preventing tests from compiling/passing due to
https://go.dev/doc/go1.24
Test Plan
Existing tests should pass