agreement: faster TestRandomizedEncodingFullDiskState #6462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The change in #6455 removed msgp.Raw from the
messagetype which meanterrSkipRawMsgpTestingwas no longer returned when callingprotocol.RandomizeObjectinTestRandomizedEncodingFullDiskState. This made the test 7x slower (~75s to ~530s). These changes hope to bound the number of iterations and size of random maps/slices made to keep the test times faster. In this PR it takes 27s.Test Plan
Existing test should pass and not take longer than 10m