-
Notifications
You must be signed in to change notification settings - Fork 518
Tests: Respect min fee consensus parameter #6456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…onsensus parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates test files to respect the consensus protocol's minimum fee parameter (MinTxnFee) instead of using hardcoded fee values. The changes ensure tests remain accurate across different consensus versions where minimum fees may vary.
- Tests now dynamically retrieve and use the network's minimum fee from consensus parameters or suggested parameters API
- Hardcoded fee values (commonly 1000 microAlgos) are replaced with protocol-aware fee calculations
- Balance calculations and assertions are updated to account for variable fees
Reviewed Changes
Copilot reviewed 65 out of 65 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| test/scripts/e2e_subs/rest.sh | Adds get_min_fee() function to retrieve network minimum fee via REST API |
| Multiple test shell scripts | Replace hardcoded fees with dynamic MIN_FEE from get_min_fee() |
| Python test files | Use goal.params().min_fee or params.MinFee instead of hardcoded values |
| Go test files | Replace hardcoded fees with proto.MinTxnFee from consensus parameters |
| Expect test files | Add GetSuggestedFee function and update fee handling |
| Config files | Update default fee values and add placeholder MinTxnFee values for testing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
test/e2e-go/features/participation/accountParticipationTransitions_test.go
Show resolved
Hide resolved
algorandskiy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plus I still suggest to rewrite AlgorandGoal::GetSuggestedFee to use curl + jq instead of submitting a transaction
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6456 +/- ##
==========================================
- Coverage 51.13% 50.97% -0.17%
==========================================
Files 668 661 -7
Lines 112101 112005 -96
==========================================
- Hits 57327 57094 -233
- Misses 51907 52037 +130
- Partials 2867 2874 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 66 out of 66 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Summary
Reworking min fee expectations in tests to consistently respect the consensus parameters.
Test Plan
Existing tests should all pass.