-
Notifications
You must be signed in to change notification settings - Fork 519
transactions: remove redundant arg from VerifiedTransactionCache #6444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6444 +/- ##
==========================================
- Coverage 50.84% 50.64% -0.20%
==========================================
Files 664 657 -7
Lines 111455 111364 -91
==========================================
- Hits 56665 56405 -260
- Misses 51924 52080 +156
- Partials 2866 2879 +13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes redundant transaction group parameters from the VerifiedTransactionCache interface methods. Since GroupContext already contains the transaction group via its signedGroupTxns field, passing the transaction group separately was unnecessary duplication.
- Removed the first
txgroupparameter fromAddandAddPaysetmethods in the interface - Updated all implementations and callers to use only the
GroupContextparameter - Simplified the internal
addmethod to extract transaction group fromGroupContext
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| data/transactions/verify/verifiedTxnCache.go | Updated interface definition and implementation to remove redundant txgroup parameters |
| data/transactions/verify/txnBatch.go | Updated calls to cache methods and removed now-unused verifiedTxnGroups slice |
| data/transactions/verify/txn.go | Updated cache method calls to pass only GroupContext |
| data/transactions/verify/verifiedTxnCache_test.go | Updated test code to use new method signatures and properly prepare GroupContext |
| data/txHandler_test.go | Updated mock implementation to match new interface |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Summary
VerifiedTransactionCachecontains these interface methods, introduced in #1757But since
GroupContextalready contains the txgroup, the first arg is redundant.Test Plan