Eval: Make counts and maxCounts simple values, not pointers #6442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change makes it clearer that there is no sharing among the storageDeltas. There was no sharing, because each pointed to object was freshly allocated, but using a pointer obscured that fact (and performed a wasted allocation.
This change will make it easier (or at least clearer) to make changes to
maxCountsif we allow transactions that update an app's global schema.Test Plan