lint: run modernize mapsloop #6434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorandskiy
previously approved these changes
Sep 4, 2025
jannotti
previously approved these changes
Sep 4, 2025
Contributor
jannotti
left a comment
jannotti
left a comment
There was a problem hiding this comment.
These are all good. In many cases, maps.Clone() would be even better. I suspect the tool doesn't do that replacement because map.Clone() is nil-preserving, while these code snippets generally allocate a 0 sized map instead. We'd have to check to see if that's ok.
jannotti
reviewed
Sep 4, 2025
jannotti
reviewed
Sep 4, 2025
algorandskiy
previously approved these changes
Sep 5, 2025
jannotti
reviewed
Sep 5, 2025
jannotti
approved these changes
Sep 5, 2025
algorandskiy
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This runs the official golang tool modernize with the
mapsloopfix.Test Plan
Existing tests should pass