Skip to content

Conversation

@winder
Copy link
Contributor

@winder winder commented Jan 25, 2022

Summary

Our SDK client generator was unable to handle this empty type. The type doesn't add anything so I'm removing it instead of adding a new feature to the generator.

Test Plan

N/A

@winder winder self-assigned this Jan 25, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3500 (a0367f2) into master (2a96a78) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3500      +/-   ##
==========================================
- Coverage   47.69%   47.68%   -0.02%     
==========================================
  Files         370      370              
  Lines       59848    59848              
==========================================
- Hits        28544    28536       -8     
- Misses      27991    28000       +9     
+ Partials     3313     3312       -1     
Impacted Files Coverage Δ
ledger/blockqueue.go 82.18% <0.00%> (-2.88%) ⬇️
network/wsPeer.go 65.83% <0.00%> (-2.23%) ⬇️
catchup/service.go 68.64% <0.00%> (-0.25%) ⬇️
network/wsNetwork.go 62.79% <0.00%> (-0.20%) ⬇️
ledger/acctupdates.go 66.73% <0.00%> (+1.14%) ⬆️
cmd/algoh/blockWatcher.go 80.95% <0.00%> (+3.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a96a78...a0367f2. Read the comment docs.

@winder winder requested a review from tsachiherman January 26, 2022 20:35
@tsachiherman tsachiherman changed the title Remove unused DeleteParticipationIdResponse type. REST API: Remove unused DeleteParticipationIdResponse type Jan 26, 2022
@tsachiherman tsachiherman merged commit 70a076e into algorand:master Jan 26, 2022
@winder winder deleted the will/remove-unused-openapi-type branch October 22, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants